Quantcast
Channel: feedbackd:4f5d3cc253369b2f5b346d83b932cce8047fe486 commits
Browsing latest articles
Browse All 40 View Live

Fix typos

View Article


udev: Update led maching for the librem5

The names changed in device tree which tickles up into userspace.

View Article


debian: Don't abuse the video group

Use a separate group for users that should be able to access the LED devices.

View Article

Document changes and release 0.0.0+git20201114

View Article

data/meson.build: fix validating theme files

The foreach loop was not used to validate all the include theme files

View Article


meson.build: compile GLib schemas on install

Run a script as a post install to make sure that all GLib schemas are compiled

View Article

fbd-feedback-manager: Allow device-specific feedbackd themes

Reads the compatible list of the device and tries to find a device-specific theme file in all directories. If no configuration is found, we fall back to a default theme file. The device-specific theme...

View Article

feedback-manager: Fix formatting

It was off in several places. Now that there's no outstanding MRs clean it up via uncrustify --replace -c phosh.cfg src/fbd-feedback-manager.c

View Article


Document changes and release 0.0.0+git20210125

View Article


implement fbd_dev_sound_stop

tracks the FdbFeedbackSounds in a GHashTable in the FdbDevSound

View Article

fbd-dev-sound: Don't leak GError

View Article

fbd-dev-sound: Don't warn when sound was cancelled

This is not an error per se.

View Article

lfb-event: Don't leak error

Don't leak the error values in the success case

View Article


tests: Run lfb_event_{get,set}_timeout

View Article

test-lfb-integration: Test invocation error

View Article


fbd-ledctrl: fix matching of trigger in list of triggers

If the trigger is the last thing in sysfs_path/LED_TRIGGER_ATTR, then the new-line at the end of the output causes g_strv_contains to fail to find the trigger in the list. This strips the new-line...

View Article

README: Fix gdbus test command

It is TriggerFeedback and not Feedback (anymore). Also add a note how to end the feedback in order to prevent loss of hearing :-).

View Article


event: Make log-domain match source file name

View Article

tests: Run event tests too

View Article

event: Remove 'g' prefix from common C types

This matchs phosh's style.

View Article

fbd-event: Add sender property

This allows us to store the DBus sender

View Article


fbd-manager: Keep DBus sender around

View Article


feedback-manager: Track DBus clients and end feedbacks if they go away

When the client goes away we build up a list of events to end feedback for to make sure the hash table isn't modified in place. tThe alternative approach would be to disconnect the...

View Article

Help emacs to indent properly

View Article

fbd-feedback-theme: Don't leak JSON node

View Article


fbd-dev-leds: Free actual FbdDevLed as well

So far we only unref'ed the device.

View Article

fbd-dev-leds: Don't leak enum_name

g_enum_to_string() is transfer full.

View Article

fbd-dev-leds: Don't leak color

g_ascii_strdown() creates a copy already.

View Article

fbd-dev-leds: Use automatic deep cleanup for device list

The current logic was fragile and failed e.g. when the FEEDBACKD_UDEV_VAL_LED would not match leaking the dev since the g_object_unref() at the end of the loop was never hit. Prevent that with...

View Article



fbd-dev-sound: Use correct cleanup for hash table

This went unnoticed since the manager forgot to cleanup this at all (see follow up commit).

View Article

fbd-feedback-manager: Make sure to dispose sound device as well

Fixes another leak.

View Article

fbd-feedback-manager: Don't leak config_path

It's assigned multiple times.

View Article

fbd-feedback-manager: Don't leak device list

View Article


Document changes and release 0.0.0+git20210426

View Article

fbd-dev-sound: whitespace

View Article

fbd-feedback-manager: Make sure theme path components are '/' separated

Previously, assembly of the theme paths for custom paths (based on `XDG_DATA_DIRS`) was performed using `g_strconcat`, which produced erroneous file paths with missing path separators due to a typo in...

View Article


README: Add explanation on custom theme paths

The README currently states that feedbackd uses the `default.json` theme, whose location is hardcoded into the application. This doesn't reflect the current state of the code. Explain the ability to...

View Article


Image may be NSFW.
Clik here to view.

feedback-manager: Search for default theme under XDG_CONFIG_HOME first

This would allow users to create their own feedback profiles without editing system files or using root privileges Signed-off-by: Pablo Correa Gómez<ablocorrea@hotmail.com>

View Article

fbd-dev-sound: Honour sound theme name for all GNOME based desktops

Phosh recently changed to XDG_CURRENT_DESKTOP=GNOME:Phosh and has since stopped using the configured theme and instead used the fallback freedesktop theme. Closes #41

View Article

examples: Unbreak python example

The method is `trigger_feedback` not `trigger`.

View Article
Browsing latest articles
Browse All 40 View Live